From ac159c24980410fc139307cdc2cfdae9e9fc2a0a Mon Sep 17 00:00:00 2001
From: Zacharias <alienfromdia@proton.me>
Date: Wed, 27 May 2026 20:20:27 +0200
Subject: [PATCH] Corrected the fact that
 `OllamaPerameter.OllamaPerameterBuilder#addProperty(String, Type, String,
 boolean)` did not respect whether it's required or not Corrected so
 `OllamaPerameter.OllamaPerameterBuilder#removeProperty(String)` also removes
 it from the required list Corrected Javadocs made
 OllamaPerameter.OllamaPerameterBuilder.Type#type a final

---
 .../me/zacharias/chat/ollama/OllamaPerameter.java   | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/Core/src/main/java/me/zacharias/chat/ollama/OllamaPerameter.java b/Core/src/main/java/me/zacharias/chat/ollama/OllamaPerameter.java
index 3049920..a851516 100644
--- a/Core/src/main/java/me/zacharias/chat/ollama/OllamaPerameter.java
+++ b/Core/src/main/java/me/zacharias/chat/ollama/OllamaPerameter.java
@@ -80,7 +80,7 @@ public class OllamaPerameter {
         ArrayList<String> required = new ArrayList<>();
         
         /**
-         * Creates a new instance of {@link OllamaPerameterBuilder}.
+         * Add an optinal perameter to this {@link OllamaPerameterBuilder}
          * @param name The name of the parameter
          * @param type The type of the parameter
          * @param description The description of the parameter
@@ -95,7 +95,7 @@ public class OllamaPerameter {
         }
         
         /**
-         * Creates a new instance of {@link OllamaPerameterBuilder}.
+         * Add a potentialy required peremeter to this {@link OllamaPerameterBuilder}.
          * @param name The name of the parameter
          * @param type The type of the parameter
          * @param description The description of the parameter
@@ -107,12 +107,14 @@ public class OllamaPerameter {
                 return this;
             }
             propertyMap.put(name, new Property(type.getType(), description));
-            this.required.add(name);
+            if(required) {
+                this.required.add(name);
+            }
             return this;
         }
         
         /**
-         * Creates a new instance of {@link OllamaPerameterBuilder}.
+         * Makes a previusly optinal perameter required for this {@link OllamaPerameterBuilder}
          * @param name The name of the parameter
          * @return The {@link OllamaPerameterBuilder}
          */
@@ -128,6 +130,7 @@ public class OllamaPerameter {
          */
         public OllamaPerameterBuilder removeProperty(String name) {
             propertyMap.remove(name);
+            required.remove(name);
             return this;
         }
         
@@ -209,7 +212,7 @@ public class OllamaPerameter {
             /**
              * The type of the parameter.
              */
-            private String type;
+            private final String type;
             
             /**
              * Gets the type of the parameter.